-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Type annotations for hash, show and wheel in commands #8018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type annotations for hash, show and wheel in commands #8018
Conversation
Hi @McSinyx , @pradyunsg , @sbidoul This is my next attempt on adding mypy annotations on some other files in |
Hi, I don't think I'm in the position for my words to be seen as reviews, but more like personal thoughts:
|
6ab9455
to
0e8093e
Compare
Thanks @McSinyx , I have removed the newlines after type comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With respect to comment here #8016 (comment), I think you can make a few changes described below. :)
001d8bc
to
3b35b41
Compare
I have applied to suggested changes to the PR. If they look good, could I please get this PR approved? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small nit, otherwise LGTM.
Thanks for the approval @sbidoul 😊 |
Towards #4748
Added type annotations to
pip._internal.commands.hash
,pip._internal.commands.show
andpip._internal.commands.wheel