-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Only install stable releases by default #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4d5c5f8
Only install stable releases by default
dstufft 4c244a4
Test the Stable/Pre-release distinction in PackageFinder
dstufft e18314e
Document the logic behind the Pre Release/Stable distinction
dstufft 9936d6b
Switch to using a fully vendored distlib inside of pip.vendor
dstufft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
language: python | ||
python: | ||
- 2.5 | ||
- 2.6 | ||
- 2.7 | ||
- 3.2 | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
all: clean vendor | ||
|
||
clean: | ||
@# Delete vendored items | ||
for i in `find . -maxdepth 1 -type d -print`; do rm -rf $i; done | ||
|
||
vendor: | ||
@# Install vendored libraries | ||
pip install -t . -r vendor.txt | ||
|
||
@# Cleanup .egg-info directories | ||
rm -rf *.egg-info |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
""" | ||
pip.vendor is for vendoring dependencies of pip to prevent needing pip to | ||
depend on something external. | ||
|
||
Files inside of pip.vendor should be considered immutable and should only be | ||
updated to versions from upstream. | ||
""" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# -*- coding: utf-8 -*- | ||
# | ||
# Copyright (C) 2012-2013 Vinay Sajip. | ||
# Licensed to the Python Software Foundation under a contributor agreement. | ||
# See LICENSE.txt and CONTRIBUTORS.txt. | ||
# | ||
import logging | ||
|
||
__version__ = '0.1.0' | ||
|
||
class DistlibException(Exception): | ||
pass | ||
|
||
try: | ||
from logging import NullHandler | ||
except ImportError: # pragma: no cover | ||
class NullHandler(logging.Handler): | ||
def handle(self, record): pass | ||
def emit(self, record): pass | ||
|
||
logger = logging.getLogger(__name__) | ||
logger.addHandler(NullHandler()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
"""Modules copied from Python 3 standard libraries, for internal use only. | ||
Individual classes and functions are found in d2._backport.misc. Intended | ||
usage is to always import things missing from 3.1 from that module: the | ||
built-in/stdlib objects will be used if found. | ||
""" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
# -*- coding: utf-8 -*- | ||
# | ||
# Copyright (C) 2012 The Python Software Foundation. | ||
# See LICENSE.txt and CONTRIBUTORS.txt. | ||
# | ||
"""Backports for individual classes and functions.""" | ||
|
||
import os | ||
import sys | ||
|
||
__all__ = ['cache_from_source', 'callable', 'fsencode'] | ||
|
||
|
||
try: | ||
from imp import cache_from_source | ||
except ImportError: | ||
def cache_from_source(py_file, debug=__debug__): | ||
ext = debug and 'c' or 'o' | ||
return py_file + ext | ||
|
||
|
||
try: | ||
callable = callable | ||
except NameError: | ||
from collections import Callable | ||
|
||
def callable(obj): | ||
return isinstance(obj, Callable) | ||
|
||
|
||
try: | ||
fsencode = os.fsencode | ||
except AttributeError: | ||
def fsencode(filename): | ||
if isinstance(filename, bytes): | ||
return filename | ||
elif isinstance(filename, str): | ||
return filename.encode(sys.getfilesystemencoding()) | ||
else: | ||
raise TypeError("expect bytes or str, not %s" % | ||
type(filename).__name__) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize I'm way, way, behind on this, but was there any discussion of making this logged info loud at the default verbosity level (i.e. warning rather than info), at least for 1.4, since it's a significant change in behavior that might confuse people if it happens silently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't around when this landed, but I agree, we should be loud about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that I remember. I'm not opposed to that change though. Might be rather noisy though since it'll give a warning for every ==dev and such for any apps that have them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, yeah, that could get noisy. I guess what we'd ideally want is just a single warning iff a stable version is selected when a prerelease version would otherwise have been selected. But that's a more complex fix than just changing this info to warning.