Skip to content

Fix remote requirements in Python 3 #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

g2p
Copy link
Contributor

@g2p g2p commented Mar 18, 2013

This was issue #760.
Also add a test (the exact url depends on pulling pypa/pip-test-package#2).

@qwcode qwcode mentioned this pull request Mar 23, 2013
@ghost ghost assigned hltbra Mar 24, 2013
@hltbra
Copy link
Contributor

hltbra commented Mar 28, 2013

Unfortunately this pull request works only for python 3. Python 3 http.client.HTTPMessage inherits from email.message.Message, which contains the get_param method.

While on python 2 httplib.Message inherits from mimetools.Message which contains `getparam``. Method name and signature are incompatible.

Also add a test (the exact url depends on pulling a change to pip-test-package).
@g2p
Copy link
Contributor Author

g2p commented Mar 28, 2013

Sorry, I've updated it to handle both cases.

@hltbra
Copy link
Contributor

hltbra commented Mar 28, 2013

Thanks @g2p.

I don't know if it is better to try/catch on `AttributeErroror let that explicit atbackwardscompat/init.py`` and import from there.

Anyway, I will test it and change it later if needed.

@hltbra
Copy link
Contributor

hltbra commented Mar 29, 2013

I am closing this pull request and opened #874 with some diffs. Thanks @g2p.

@hltbra hltbra closed this Mar 29, 2013
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants