Skip to content

don't install or build wheels for distribute in python 3 #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2013
Merged

don't install or build wheels for distribute in python 3 #937

merged 1 commit into from
May 17, 2013

Conversation

qwcode
Copy link
Contributor

@qwcode qwcode commented May 11, 2013

a solution for #891 and #650

for example, users currently can't do either of these practical commands in py3 without failing with distribute 2to3 related errors (due to pyramid depending on setuptools, which is converted to distribute in py3)

  • pip wheel pyramid
  • pip install -U pyramid

the change:

  • in py3, skip "distribute" for wheel building or installs.
  • uses get a notify message of the skip

I think it's acceptable to just declare that in py3, pip can not reinstall/downgrade/upgrade distribute. I can followup with some changes to the docs to explain the situation, and how they could do it manually.

this problem will go away after the setuptools/distribute merge, due to the new setuptools having py2-py3 compatible code that does not require 2to3

@qwcode
Copy link
Contributor Author

qwcode commented May 11, 2013

pypi problems causing test failures...

@qwcode
Copy link
Contributor Author

qwcode commented May 16, 2013

@pfmoore , you're familiar with this. ok? or no?

@pfmoore
Copy link
Member

pfmoore commented May 16, 2013

I wasn't but I'll take a look later today. Is this because pyramid includes an explicit dependency on distribute/setuptools? Assuming so, the fix sounds reasonable at first glance.

@qwcode
Copy link
Contributor Author

qwcode commented May 17, 2013

yes, the motivation was a popular project like pyramid with a dependency on "setuptools"

qwcode added a commit that referenced this pull request May 17, 2013
don't install or build wheels for distribute in python 3
@qwcode qwcode merged commit 0994c12 into pypa:develop May 17, 2013
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants