Skip to content

Fix environment variable expansion with extras #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

jtratner
Copy link
Collaborator

Current master tests are failing because of small bug in environment variable expansion.

I.e., this fails:

$ pipenv install 'requests[socks]'
# long traceback ending with
  File "/Users/jtratner/pipenv/pipenv/vendor/pipfile/api.py", line 103, in parse
    parsed_toml = self.inject_environment_variables(toml.loads(content))
  File "/Users/jtratner/pipenv/pipenv/vendor/pipfile/api.py", line 79, in inject_environment_variables
    d[k] = self.inject_environment_variables(v)
  File "/Users/jtratner/pipenv/pipenv/vendor/pipfile/api.py", line 79, in inject_environment_variables
    d[k] = self.inject_environment_variables(v)
  File "/Users/jtratner/pipenv/pipenv/vendor/pipfile/api.py", line 81, in inject_environment_variables
    d[k] = [self.inject_environment_variables(e) for e in v]
  File "/Users/jtratner/pipenv/pipenv/vendor/pipfile/api.py", line 75, in inject_environment_variables
    for k, v in d.items():
AttributeError: 'unicode' object has no attribute 'items'

but this PR gets it to work again - woo!

I will open up an additional PR against the pipfile repo sometime later, just figured it'd be good to unbreak the build :) (I also need to fully grok how extras get converted into a dictionary format)

cc @dvf

@dvf
Copy link
Contributor

dvf commented Mar 20, 2018

Nice catch, thanks @jtratner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants