Skip to content

feature: notice if there is no long_description #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brainwane opened this issue Feb 1, 2018 · 2 comments
Closed

feature: notice if there is no long_description #64

brainwane opened this issue Feb 1, 2018 · 2 comments

Comments

@brainwane
Copy link
Contributor

We ought to warn the user about a problem if the long_description is entirely absent from setup.py.

Example: https://github.com/rytilahti/python-miio/blob/21065f696c2167e86d72f90e660a14dcef573587/setup.py has no long_description. But when I run readme-renderer version 17.2 in the root of that repo, in a Python 3.5.3 virtualenv, doesn't speak up about an error:

$ python setup.py check -r -s
running check
$

cc @rytilahti
@brainwane
Copy link
Contributor Author

@di what's your take on this feature idea?

@di
Copy link
Member

di commented Mar 19, 2018

Sounds like a great idea.

theacodes pushed a commit to theacodes/readme_renderer that referenced this issue Mar 20, 2018
Warn about missing long description
1577cd1 
Additionally, add comprehensive tests for the disutils integration.

Resolves pypa#64
@theacodes theacodes mentioned this issue Mar 20, 2018
Merged
theacodes pushed a commit that referenced this issue Mar 30, 2018
Warn about missing long description (#69)
506da6a 
Additionally, add comprehensive tests for the disutils integration.

Resolves #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@di @brainwane