Skip to content

version.py including __all__ #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2024
Merged

version.py including __all__ #1076

merged 3 commits into from
Oct 3, 2024

Conversation

jamesbraza
Copy link
Contributor

Closes #1075

Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely, thanks
lets add a changelog fragment as well

@jamesbraza
Copy link
Contributor Author

Nice, I just did it 👌 please let me know if I did it incorrectly

@jamesbraza
Copy link
Contributor Author

Thanks for the approval. I don't have the ability to merge this fyi

@RonnyPfannschmidt RonnyPfannschmidt merged commit be34dd1 into pypa:main Oct 3, 2024
18 checks passed
@RonnyPfannschmidt
Copy link
Contributor

the change log fragment was not matching the tooling, but its my falt it wasn't documented well enough - thanks for making it nice and doing the extra round-trip, to ensure its awesome 👍

@jamesbraza jamesbraza deleted the all-in-version branch October 3, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include __all__ in autogenerated version_file
2 participants