solved: Installation failed due to reversed boolean

[ghost]

Originally reported by: Anonymous

---

On Sunday, 2014-01-19, I downloaded and ran the script posted at https://bitbucket.org/pypa/setuptools/raw/bootstrap/ez_setup.py yielded these messages:

'''
Downloading https://pypi.python.org/packages/source/s/setuptools/setuptools-2.1.tar.gz
Extracting in d:\users\xxxxxxx\appdata\local\temp\tmpvw3rn3
Now working in d:\users\xxxxxxx\appdata\local\temp\tmpvw3rn3\setuptools-2.1
Installing Setuptools
Something went wrong during the installation.
See the error message above.
'''

The last two messages are from the try block in _install(tarball, install_args=()):

    if not _python_cmd('setup.py', 'install', *install_args):
        log.warn('Something went wrong during the installation.')
        log.warn('See the error message above -- exit code is 2.')

The last line of _python_cmd(*args) is:

    return subprocess.call(args) == 0

which means that (pseudo code):

if subprocess.call(args) succeeds:
    _python_cmd returns False to _install
    _install issues the messages given above
    _install calls sys.exit()

When I changed the _python_cmd boolean to:

    return subprocess.call(args) == 1

setuptools v. 0.6c11 was installed without error and I was able to install ipython and some other packages with no problems.

I'm running Python 2.7.6 on Windows 7.

---

• Bitbucket: https://bitbucket.org/pypa/setuptools/issue/140

[ghost]

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):

---

I believe you're mistaken. Subprocess.call returns the process exit code, which is 0 upon success. Thus if the subprocess call succeeds, _python_cmd returns True. Then, _install does not print the messages or exit.

Furthermore, it's very strange that you've downloaded setuptools-2.1, yet 0.6c11 is installed.

I run this script on clean and dirty Windows environments all the time without incident. I'm pretty sure the logic is accurate. The code suggests "See the error message above". What was the error message above?