Skip to content

customized URL openers are bypassed #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Aug 6, 2013 · 8 comments
Closed

customized URL openers are bypassed #61

ghost opened this issue Aug 6, 2013 · 8 comments

Comments

@ghost
Copy link

ghost commented Aug 6, 2013

Originally reported by: wichert (Bitbucket: wichert, GitHub: wichert)


When using setuptools 0.8 and later lovely.buildouthttp no longer works.


@ghost
Copy link
Author

ghost commented Aug 6, 2013

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


Looking at the changes between 0.7.8 and 0.8, I don't see anything that suggests that handling of URL opening was changed at all.

Do you know if the issue exists in 0.7.x? What is the undesirable behavior and what is the expected behavior? Is there an error message or does the plugin simply not appear to be activated? Can you tell if the plugin is installed (i.e. buildouthttp.install()) but not activated, or install() is never called?

@ghost
Copy link
Author

ghost commented Aug 6, 2013

Original comment by wichert (Bitbucket: wichert, GitHub: wichert):


I don't know if this issue exists in 0.7; as a user setuptools seems to have most from 0.6c11 to 0.8 in a very short time almost as if 0.7 was skipped, and then almost as quickly to the 0.9 series. I don't think I have ever had setuptools 0.7 installed.

What I am seeing is that using zc.buildout 1.7 with lovely.buildouthttp uses authentication to access find-links, but as soon as I upgrade to zc.buildout 2 which uses setuptools 0.8 or later no authentication attempt is made. Since zc.buildout uses setuptools for all downloading/installation my instinct is that something in setuptools changed which broke lovely.buildouthttp.

I don't know how I can check if the plugin is installed, beyond noticing that buildout installs it as a buildout extension so I'm assuming it is installed normally.

@ghost
Copy link
Author

ghost commented Aug 6, 2013

Original comment by wichert (Bitbucket: wichert, GitHub: wichert):


I just tested setuptools 0.9.8 with zc.buildout 1.7.3 and this had the same problem. Downgrading to setuptools 0.6.c11 made everything work again.

@ghost
Copy link
Author

ghost commented Aug 6, 2013

Original comment by fdrake (Bitbucket: fdrake, GitHub: fdrake):


We had a similar problem with zc.buildoutsftp with newer versions of setuptools. This is related to the support for SSL verification added in setuptools.

setuptools doesn't change the installed opener, but does create a new one and uses that instead, so just installing an opener is no longer sufficient.

We need a better way to allow multiple buildout extensions to extend how URLs are opened, and... this really isn't specific to buildout.

@ghost
Copy link
Author

ghost commented Aug 6, 2013

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


I've updated the title to reflect that this issue likely emerged with setuptools 0.7, which added the SSL support and altered the way URLs are opened.

@ghost
Copy link
Author

ghost commented Feb 9, 2014

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


Is this issue resolved? I see that lovely.buildouthttp had a release fixing issues with setuptools 0.7 and later. If it would help for setuptools to expose a better API for customizing URL opening, please open a new ticket proposing the change to the API.

@ghost
Copy link
Author

ghost commented Feb 10, 2014

Original comment by wichert (Bitbucket: wichert, GitHub: wichert):


lovely.buildouthttp indeed works around this issue now.

@ghost
Copy link
Author

ghost commented Feb 10, 2014

Original comment by wichert (Bitbucket: wichert, GitHub: wichert):


I created #149 to request an API to hook into downloading.

@ghost ghost added major bug labels Mar 29, 2016
@ghost ghost closed this as completed Mar 29, 2016
jaraco pushed a commit that referenced this issue Jun 12, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants