Skip to content

Remove check for PYTHONDONTWRITEBYTECODE #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jaraco opened this issue May 29, 2013 · 4 comments
Closed

Remove check for PYTHONDONTWRITEBYTECODE #430

jaraco opened this issue May 29, 2013 · 4 comments
Milestone

Comments

@jaraco
Copy link
Member

jaraco commented May 29, 2013

Virtualenv is opinionated about the user's environment. It claims that PYTHONDONTWRITEBYTECODE is not compatible with setuptools, though the code makes no reference to a bug report or other indication as to why setuptools is not compatible.

Presumably, with 0.7, setuptools is now compatible with that variable. This check should probably be removed. Is there anything else that needs to be done?

@pnasrat
Copy link

pnasrat commented May 29, 2013

For background see #179

We can remove it when we enforce setuptools >= 0.7 as per Issue #428

I've been a bit out of the loop lately on that - I guess just submit a PR to remove this and next release should have this in (thus added to milestone).

@jaraco
Copy link
Member Author

jaraco commented May 29, 2013

Thanks for the lead. I found the distribute bug report which references the fix. I've confirmed this fix is part of setuptools 0.7.

I was recommending using old versions of setuptools to upgrade to the latest:

virtualenv --setuptools env
env/bin/easy_install <setuptools-0.7b4>

But that technique won't work when PYTHONDONTWRITEBYTECODE is set. Alas, this raises the importance of setuptools #4.

@pfmoore
Copy link
Member

pfmoore commented Jun 13, 2013

Pull request #432 removes this check (as part of the larger change to switch to setuptools 0.7+)

@pfmoore
Copy link
Member

pfmoore commented Jun 15, 2013

Pull request #432 now merged.

@pfmoore pfmoore closed this as completed Jun 15, 2013
@pypa pypa locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants