Skip to content

Integrate setuptools 0.7+ support #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2013
Merged

Conversation

pfmoore
Copy link
Member

@pfmoore pfmoore commented Jun 11, 2013

Initial version of setuptools 0.7 support

@qwcode
Copy link

qwcode commented Jun 13, 2013

cool, I'll take a look tomorrow, and also run the pip test suite using this branch of virtualenv.

@qwcode
Copy link

qwcode commented Jun 14, 2013

lgtm. I say merge it unless there was any concerns? or any other unspoken changes you were thinking of?
and you could just delete those old options instead of leaving them commented.

I'm pretty close with a corresponding pip branch, that I could merge after.
until virtualenv-1.10 is released, the pip tox and travis files would have to point at git+https://github.com/pypa/virtualenv@develop#egg=virtualenv

@pfmoore
Copy link
Member Author

pfmoore commented Jun 15, 2013

OK, I'll delete the old options, leave it the rest of the day for other comments, them commit.

The only real concern I had was whether it was OK to delete options rather than leave them as do-nothing for backward compatibility (the second of the 2 commits here that fixed the .travis.yml file was needed precisely because the options had been removed). But I have a hard time imagining a case where someone would have a script that needed to work with both of virtualenv 1.9- and 1.10+, so I don't intend to worry about the issue unless someone has a better reason than "it might matter"...

pfmoore added a commit that referenced this pull request Jun 15, 2013
Integrate setuptools 0.7+ support
@pfmoore pfmoore merged commit 86f3fd7 into pypa:develop Jun 15, 2013
@pfmoore pfmoore deleted the setuptools-0.7 branch September 26, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants