-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Activation scripts for next-gen virtualenv #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c53707d
to
beb68b4
Compare
57c337b
to
81aedfe
Compare
81aedfe
to
f82430c
Compare
7534786
to
2c4dc5f
Compare
Signed-off-by: Bernat Gabor <[email protected]>
2c4dc5f
to
3e60d98
Compare
Signed-off-by: Bernat Gabor <[email protected]>
Signed-off-by: Bernat Gabor <[email protected]>
Signed-off-by: Bernat Gabor <[email protected]>
Signed-off-by: Bernat Gabor <[email protected]>
5a54c43
to
1809bf7
Compare
Signed-off-by: Bernat Gabor <[email protected]>
1809bf7
to
47be424
Compare
Signed-off-by: Bernat Gabor <[email protected]>
5f55f3b
to
3ad79b4
Compare
Signed-off-by: Bernat Gabor <[email protected]>
1fd91c1
to
34ea668
Compare
Signed-off-by: Bernat Gabor <[email protected]>
84e79ab
to
82dc174
Compare
ce9949d
to
dc436a8
Compare
Signed-off-by: Bernat Gabor <[email protected]>
55c82ae
to
f5a4c55
Compare
Signed-off-by: Bernat Gabor <[email protected]>
80994cb
to
745e324
Compare
gaborbernat
approved these changes
Dec 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now done.
PS. @saytosid One thing that's still missing is tests for the python activator, but let's add it a follow-up PR, if you have time anytime soon.
gaborbernat
pushed a commit
that referenced
this pull request
Dec 15, 2019
gaborbernat
pushed a commit
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Activators for various activation scripts
Thanks for contributing a pull request, see checklist all is good!
docs/changelog
folder