Skip to content

Fix typo found by codespell #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Fix typo found by codespell #591

merged 1 commit into from
Dec 18, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ad14b2) 72.17% compared to head (9f114a8) 72.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #591   +/-   ##
=======================================
  Coverage   72.17%   72.17%           
=======================================
  Files          13       13           
  Lines        1071     1071           
=======================================
  Hits          773      773           
  Misses        298      298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agronholm
Copy link
Contributor

Perhaps the grammar should also be fixed while at it?

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Dec 18, 2023

Done.

By the way, get_base_class_and_magic_number() already tests the value of seek internally:

if seek is None:
seek = lib_file.tell()
else:
lib_file.seek(seek)

Would you agree to pass test to get_base_class_and_magic_number() instead of testing it in read_mach_header()? No need to test twice:

if seek is not None:
lib_file.seek(seek)
base_class, magic_number = get_base_class_and_magic_number(lib_file)

@agronholm agronholm merged commit b57d685 into pypa:main Dec 18, 2023
@agronholm
Copy link
Contributor

Thanks.

@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell branch December 18, 2023 21:07
abravalheri pushed a commit to abravalheri/setuptools that referenced this pull request Apr 28, 2025
abravalheri pushed a commit to abravalheri/setuptools that referenced this pull request Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants