Skip to content

Update VLC guard against caching stale content at edge #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2022
Merged

Update VLC guard against caching stale content at edge #105

merged 1 commit into from
Sep 26, 2022

Conversation

ewdurbin
Copy link
Member

This is an attempt to address pypi/warehouse#12214

It's not clear if there is any technical difference between req.http.Fastly-FF and fastly.ff.visits_this_service, but the docs now recommend this.

@ewdurbin ewdurbin requested a review from di September 26, 2022 17:10
di
di approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This brings it back in line w/ the docs but I don't think this is actually going to change anything, presumably Fastly-FF was either an empty or non-empty list before, so the behavior should be exactly the same.

@ewdurbin
Copy link
Member Author

I anticipate the same behavior also, just want to try something 😕

@ewdurbin ewdurbin merged commit b2af02a into main Sep 26, 2022
@ewdurbin ewdurbin deleted the update_edge_guard_for_stale_content branch September 26, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@di di di approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewdurbin @di