Trove classifiers API endpoint (#1243)

Author: Karan Goel

tests/unit/legacy/api/test_pypi.py

@@ -17,6 +17,8 @@
 
 from warehouse.legacy.api import pypi
 
+from ....common.db.classifiers import ClassifierFactory
+
 
 def test_exc_with_message():
     exc = pypi._exc_with_message(HTTPBadRequest, "My Test Message.")
@@ -67,3 +69,14 @@ def test_forbidden_legacy():
     exc, request = pretend.stub(), pretend.stub()
     resp = pypi.forbidden_legacy(exc, request)
     assert resp is exc
+
+
+def test_list_classifiers(db_request):
+    ClassifierFactory.create(classifier="foo :: bar")
+    ClassifierFactory.create(classifier="foo :: baz")
+    ClassifierFactory.create(classifier="fiz :: buz")
+
+    resp = pypi.list_classifiers(db_request)
+
+    assert resp.status_code == 200
+    assert resp.text == "fiz :: buz\nfoo :: bar\nfoo :: baz"

tests/unit/test_routes.py

@@ -187,6 +187,11 @@ def add_xmlrpc_endpoint(endpoint, pattern, header, domain=None):
             domain=warehouse,
         ),
         pretend.call("legacy.api.pypi.doap", "doap", domain=warehouse),
+        pretend.call(
+            "legacy.api.pypi.list_classifiers",
+            "list_classifiers",
+            domain=warehouse,
+        ),
     ]
 
     assert config.add_pypi_action_redirect.calls == [

warehouse/legacy/api/pypi.py

@@ -11,8 +11,11 @@
 # limitations under the License.
 
 from pyramid.httpexceptions import HTTPGone
+from pyramid.response import Response
 from pyramid.view import forbidden_view_config, view_config
 
+from warehouse.classifiers.models import Classifier
+
 
 def _exc_with_message(exc, message):
     # The crappy old API that PyPI offered uses the status to pass down
@@ -72,3 +75,17 @@ def forbidden_legacy(exc, request):
     # the default forbidden handler we have which does redirects to the login
     # view, which we do not want on this API.
     return exc
+
+
+@view_config(route_name="legacy.api.pypi.list_classifiers")
+def list_classifiers(request):
+    classifiers = (
+        request.db.query(Classifier.classifier)
+               .order_by(Classifier.classifier)
+               .all()
+    )
+
+    return Response(
+        text='\n'.join(c[0] for c in classifiers),
+        content_type='text/plain; charset=utf-8'
+    )

warehouse/routes.py

@@ -145,6 +145,11 @@ def includeme(config):
         "doap",
         domain=warehouse,
     )
+    config.add_pypi_action_route(
+        "legacy.api.pypi.list_classifiers",
+        "list_classifiers",
+        domain=warehouse,
+    )
 
     # Legacy XMLRPC
     config.add_xmlrpc_endpoint(