Trove classifiers API endpoint

[karan]

#1241

WIP - @dstufft - I can't get the test to work. Any hints? :)

    def test_list_classifiers(pyramid_request):
        pyramid_request = pretend.stub(
            db=pretend.stub(
                query=pretend.stub(
                    order_by=pretend.stub(
                        all=lambda: 'abc'
                    )
                ),
            ),
        )
>       resp = pypi.list_classifiers(pyramid_request)

tests/unit/legacy/api/test_pypi.py:84:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    @view_config(route_name="legacy.api.pypi.list_classifiers")
    def list_classifiers(request):
        classifiers = (
>           request.db.query(Classifier.classifier)
                      .order_by(Classifier.classifier)
                      .all()
        )
E       TypeError: 'stub' object is not callable

warehouse/legacy/api/pypi.py:83: TypeError

[dstufft]

@karan it's trying to call pyramid_request.db.query(), but you have it as a stub object instead of a callable. In pretend you want that to be pretend.call_recorder(lambda *args: SOMEQUERYOBJECT).

Although I recommend not trying to stub out database access, and instead just using the db_request fixture to enable DB access and then insert some classifiers into the database and running the view to make sure it finds them.

[karan]

@dstufft Ah perfect. I was a bit confused about db_request but now it makes sense!

Pushed the changes.

[dstufft]

✨ 🍰