Skip to content

Verify Home-page and Download-URL URLs #16540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
facutuesca opened this issue Aug 21, 2024 · 4 comments · Fixed by #16568
Closed

Verify Home-page and Download-URL URLs #16540

facutuesca opened this issue Aug 21, 2024 · 4 comments · Fixed by #16568
Labels
feature request UX/UI design, user experience, user interface

Comments

@facutuesca
Copy link
Contributor

What's the problem this feature will solve?
Currently, only URLs specified via Project-URL are verified (as part of the work for #8635).

However, the Home-page and Download-URL URLs are not verified. These are currently stored in the backend inside the Release object as plain strings, as opposed to the URLs from Project-URL which have their own type (ReleaseURL) and are stored in their own table along with their verification status.

Since these two URLs are not verified, they are always returned as unverified (via #16531).

Describe the solution you'd like
We can change the backend so that these two URLs are verified during upload, and their verification status is stored, similar to what we do for URLs in Project-URL fields.

/cc @di @woodruffw

@facutuesca facutuesca added feature request requires triaging maintainers need to do initial inspection of issue labels Aug 21, 2024
@woodruffw woodruffw added UX/UI design, user experience, user interface and removed requires triaging maintainers need to do initial inspection of issue labels Aug 21, 2024
@miketheman
Copy link
Member

Since these two URLs are not verified, they are always returned as unverified (via #16531).

They are also no longer displayed at all.

@facutuesca
Copy link
Contributor Author

They are also no longer displayed at all.

@miketheman That's what #16531 fixes

@di
Copy link
Member

di commented Aug 21, 2024

Part of me wonders if we should just store these as ReleaseURLs on upload and stop special-casing the metadata fields... but I think that would probably complicate things when we return project_urls in the API results.

@miketheman
Copy link
Member

They are also no longer displayed at all.

@miketheman That's what #16531 fixes

@facutuesca thanks, I confirmed the fix is there after a page cache re-render.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request UX/UI design, user experience, user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants