Fix missing unverified URLs #16531
Merged
Fix missing unverified URLs #16531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facutuesca
force-pushed
the
fix-missing-unverified-urls
branch
from
7247602 to
c4eb9e2
Compare
woodruffw
reviewed
Aug 21, 2024
woodruffw
reviewed
Aug 21, 2024
facutuesca
force-pushed
the
fix-missing-unverified-urls
branch
from
0f6d0ed to
a80c853
Compare
woodruffw
approved these changes
Aug 21, 2024
di
approved these changes
Aug 21, 2024
di
reviewed
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, verified and unverified URLs are shown by getting them from a
Releaseobject using theRelease.urls_by_verify_status()method. However, this method only takes into account URLs inRelease._project_urls, ignoring the fieldsRelease.home_pageandRelease.download_url, which means the URLs in those two fields are not displayed (unless the URLs are also present in_project_urls)Since those two fields are currently just
strand do not store any verification information, we should consider them as unverified and return them when the user callsRelease.urls_by_verify_status(False), unless they happen to also be present in_project_urlsas verified URLs.This PR fixes
Release.urls_by_verify_statusso that it also includesRelease.home_pageandRelease.download_urlin the list of unverified URLs, iff those URLs are not verified inRelease._project_urls.cc @woodruffw