-
Notifications
You must be signed in to change notification settings - Fork 1k
Make callout block component dismissible (optionally) #3126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@di - I feel like I should apply the 'good first issue' label here, but I'm not sure about the complexity of adding a cookie, etc. Can you please confirm? Thx |
Yep, I think this could be done pretty easily on the frontend with a Stimulus.js controller and |
I should be more specific here - we don't necessarily want to make all of the In the same way, it would be nice for users to be able to remove documentation information boxes ( Again, we don't want to make all |
So, ideally, we could add a "dismissable" controller that would hide the target element, which we could reuse for pretty much anything. |
I can make a PR with the appropriate CSS styles if someone else can provide the JS :) |
@aalmazan now that cryvate's started working again on that other issue, would you like to try this one? |
@brainwane Sure thing. Submitted a partial PR with a quick question in #3202 . |
Notification bars are now dismissible, thanks to #3202 |
Is #3361 a duplicate of this? |
@99 is working on this! |
I see this ticket is linked to a merged PR. Should we close it or is it still applicable ? |
Uh oh!
There was an error while loading. Please reload this page.
Right now, we have 2 notification bars at the top of PyPI.io
It would be nice to allow the users to dismiss these notifications, and remember that they've been dismissed.
If someone would be willing to make a PR with a simple 'close' link, I can style the button :)
Good First Issue: This issue is good for first time contributors. If you've already contributed to Warehouse, please work on another issue without this label instead. If there is not a corresponding pull request for this issue, it is up for grabs. For directions for getting set up, see our Getting Started Guide. If you are working on this issue and have questions, please feel free to ask them here,
#pypa-dev
on Freenode, or the pypa-dev mailing list.The text was updated successfully, but these errors were encountered: