Skip to content

Collaborators form: Change default selection to 'maintainer' #3156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nlhkabu opened this issue Mar 7, 2018 · 5 comments
Closed

Collaborators form: Change default selection to 'maintainer' #3156

nlhkabu opened this issue Mar 7, 2018 · 5 comments
Labels
good first issue This issue is ideal for first-time contributors! usability UX/UI design, user experience, user interface

Comments

@nlhkabu
Copy link
Contributor

nlhkabu commented Mar 7, 2018

From user testing:

On the management collaborators page (manage/project/<projectname>/collaboration/) - we have a form to add a new owner or maintainer:

screenshot from 2018-03-07 07-29-08

Currently, the default selected value is 'owner' - we should change the order, so that the default value is 'maintainer'.

Reason: Adding a maintainer is less dangerous :)


Good First Issue: This issue is good for first time contributors. If you've already contributed to Warehouse, please work on another issue without this label instead. If there is not a corresponding pull request for this issue, it is up for grabs. For directions for getting set up, see our Getting Started Guide. If you are working on this issue and have questions, please feel free to ask them here, #pypa-dev on Freenode, or the pypa-dev mailing list.

@nlhkabu nlhkabu added good first issue This issue is ideal for first-time contributors! UX/UI design, user experience, user interface labels Mar 7, 2018
@nlhkabu
Copy link
Contributor Author

nlhkabu commented Mar 7, 2018

For consistency, we should also change the order of the information above the table, so that maintainer is listed first.

screenshot from 2018-03-07 08-29-05

Related to #3157

@brainwane brainwane added this to the 6. Post Legacy Shutdown milestone Mar 8, 2018
@brainwane
Copy link
Contributor

@aalmazan Would you be interested in doing this?

@jmuzsik
Copy link

jmuzsik commented Mar 17, 2018

Hi, I'll work on this, and I can do #3157 simultaneously.

Ought I use the exact text used in specified in #3157 or is there anything else that should be edited in this view?

Thanks!

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Mar 17, 2018

Great! thanks @jmuzsik! Yes, let's go with the exact text - thank you!

di pushed a commit that referenced this issue Mar 19, 2018
* enhancement - in reference to #3157 and #3156

* enhancement - in reference to #3157 and #3156

* enhancement - in reference to #3157 and #3156

* enhancement - in reference to #3157 and #3156

* enhancement - in reference to #3157 and #3156
@di
Copy link
Member

di commented May 15, 2018

Fixed in #3313.

@di di closed this as completed May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This issue is ideal for first-time contributors! usability UX/UI design, user experience, user interface
Projects
None yet
Development

No branches or pull requests

4 participants