Skip to content

Add required attribute to input element in Request Password Reset page #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
waseem18 opened this issue Mar 11, 2018 · 1 comment · Fixed by #3230
Closed

Add required attribute to input element in Request Password Reset page #3223

waseem18 opened this issue Mar 11, 2018 · 1 comment · Fixed by #3230
Labels
good first issue This issue is ideal for first-time contributors! HTML requires change to HTML files usability

Comments

@waseem18
Copy link
Contributor

waseem18 commented Mar 11, 2018

In Request Password Reset page the input element doesn't have required attribute. Hitting Request Password Reset button with empty input sends a POST call and then adds This field is required message.
It's better to have a required attribute which marks the input as required.


Good First Issue: This issue is good for first time contributors. If you've already contributed to Warehouse, please work on another issue without this label instead. If there is not a corresponding pull request for this issue, it is up for grabs. For directions for getting set up, see our Getting Started Guide. If you are working on this issue and have questions, please feel free to ask them here, #pypa-dev on Freenode, or the pypa-dev mailing list.

Screenshot Required: If your pull request makes a visual change, please include a screenshot of your update. This helps our team give you feedback faster.

@nlhkabu nlhkabu added good first issue This issue is ideal for first-time contributors! HTML requires change to HTML files labels Mar 11, 2018
@nlhkabu
Copy link
Contributor

nlhkabu commented Mar 11, 2018

Thanks @waseem18 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This issue is ideal for first-time contributors! HTML requires change to HTML files usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants