-
Notifications
You must be signed in to change notification settings - Fork 1k
Password strength gauge stimulus #3243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Password strength gauge stimulus #3243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it's probably too soon to call something "idiomatic stimulus", I think it would be more idiomatic to make these separate controllers than controllers that inherit from each other. There's not much to share between them and I think it would generally be cleaner.
That said, I have not given this PR a super close look, so if there's a good reason why that's wrong I could probably be convinced.
@@ -11,10 +11,18 @@ | |||
* See the License for the specific language governing permissions and | |||
* limitations under the License. | |||
*/ | |||
|
|||
/* global zxcvbn */ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidental comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint
appeaser 😄
Also, thank you for tackling this! |
8d4e01a
to
73b6ec1
Compare
73b6ec1
to
f570e07
Compare
I've updated this to a much simpler approach of adding multiple controllers to the form. I feel like some lines are getting a big too wide to read comfortably. I'd be in favor of something like:
Would we consider disabling the template linting rule around single line echo statements to allow that? |
@yeraydiazdiaz I think that'd be fine. |
Seems it's not something we can disable in the |
This builds on #3219 addressing #3197 and #3223
More importantly includes a refactor of the password gauge functionality to Stimulus.
There's a few decisions I made around the ability to compose components using JS "mixins" which I'm not sure it's "idiomatic Stimulus" if there is such a thing. Here's three captures of the end results in three areas:
Reset password:

Register:

Update password:

Hopefully it makes sense and we can move forwards with Stimulus using this pattern.