Add search result ordering #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This looks good to me, the design side stuff @nlhkabu will have to chime in on. |
|
Looks great @di! Thankyou :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the "sorting" part of #702 by making the "Order packages by" options functional. Search results can now be sorted by the date of the latest release.
@nlhkabu This also makes two small UI changes.
First, it adds the release creation date (a.k.a. "upload" date) to each individual search result, to make it clear how the results are being ordered:
Before:
After:
Second, it also adds the current search term to the search field, which I think improves usability when doing multiple searches (you don't have to retype the entire term again):
Before:
After:
