Skip to content

Add repository name to github section #10925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

merwok
Copy link
Contributor

@merwok merwok commented Mar 11, 2022

Fixes #10917

Copy link
Contributor

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll let one of the admins merge this. :)

@merwok
Copy link
Contributor Author

merwok commented Mar 14, 2022

Do people think it’s a problem if a repo link ends up in the project URLs section and the github stats section?

@pradyunsg
Copy link
Contributor

I certainly don't! They both serve distinct functions IMO -- one presenting the preferred language from the package author and another presenting a consistent + at-a-glance view of what the package reports as its URL.

@di
Copy link
Member

di commented Mar 14, 2022

Aside from the other discussion in #10917, this doesn't seem to actually do what's originally requested in that issue:

Change "GitHub statistics:" to instead be "GitHub: {repo-name}". So, for pip, that would be "GitHub: pypa/pip".

@merwok
Copy link
Contributor Author

merwok commented Mar 14, 2022

Yes, I disagreed with that specific part of the proposal! Prefer to keep the full existing heading, and clarify what we are reading (let’s not assume that everyone understands «some letters slash more letters», «some word hyphen sig», «r slash word», etc 😉)

@pradyunsg
Copy link
Contributor

And I think this is perfectly reasonable as well. :)

@merwok merwok requested a review from a team as a code owner July 11, 2022 10:53
@merwok
Copy link
Contributor Author

merwok commented Jul 11, 2022

@di @dstufft could you review this? I can change the code if you both want the format github: username/repo, but I do think my version is clearer!

@merwok merwok closed this Sep 30, 2022
@merwok merwok deleted the display-github-repo branch October 9, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show repository name, in the GitHub statistics section
3 participants