Skip to content

Conversation

kianmeng
Copy link

No description provided.

@miketheman
Copy link
Member

Nice! Would you mind running make translations as well to update the translation files?

@di
Copy link
Member

di commented Jun 12, 2022

Also, did you use some sort of tool to find these? If so, is it someone we can integrate into our linting?

@kianmeng
Copy link
Author

@miketheman Done, nothing being added.

$ make translations
docker-compose run --rm web bin/translations
[+] Running 3/0
 ⠿ Container 0611_warehouse-redis-1          Running                                                 0.0s
 ⠿ Container 0611_warehouse-db-1             Running                                                 0.0s
 ⠿ Container 0611_warehouse-elasticsearch-1  Running                                                 0.0s

$ git status
On branch fix-typos
nothing to commit, working tree clean

@di
https://github.com/codespell-project/codespell
https://github.com/codespell-project/actions-codespell

@di
Copy link
Member

di commented Jun 15, 2022

Thanks. Could you integrate it into our linting as well in this PR?

@kianmeng kianmeng force-pushed the fix-typos branch 3 times, most recently from e375eda to 30c893a Compare June 22, 2022 13:55
@kianmeng
Copy link
Author

@di Done. Please check.

$ make lint
docker-compose run --rm web bin/lint
[+] Running 3/0
 ⠿ Container 0611_warehouse-db-1             Running                                                            0.0s
 ⠿ Container 0611_warehouse-redis-1          Running                                                            0.0s
 ⠿ Container 0611_warehouse-elasticsearch-1  Running                                                            0.0s
+ python -m codespell_lib -S '*.po,*.js,*.json,*.svg,*.scss' -I .codespellignore
+ python -m flake8 .
+ python -m black --check gunicorn-prod.conf.py gunicorn-uploads.conf.py warehouse/ tests/                        
All done! ✨ 🍰 ✨       
558 files would be left unchanged.
+ python -m isort --check gunicorn-prod.conf.py gunicorn-uploads.conf.py warehouse/ tests/                           + python -m doc8 --allow-long-titles README.rst CONTRIBUTING.rst docs/ --ignore-path docs/_build/
Scanning...
Validating...
========
Total files scanned = 29
Total files ignored = 0
Total accumulated errors = 0
Detailed error counts:
    - doc8.checks.CheckCarriageReturn = 0
    - doc8.checks.CheckIndentationNoTab = 0
    - doc8.checks.CheckMaxLineLength = 0
    - doc8.checks.CheckNewlineEndOfFile = 0
    - doc8.checks.CheckTrailingWhitespace = 0
    - doc8.checks.CheckValidity = 0
+ python -m curlylint ./warehouse/templates
All done! ✨ 🍰 ✨

+ python -m mypy -p warehouse
Success: no issues found in 300 source files
docker-compose run --rm static bin/static_lint
+ export LC_ALL=en_US.UTF-8
+ LC_ALL=en_US.UTF-8
bin/static_lint: line 8: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory
+ export LANG=en_US.UTF-8
+ LANG=en_US.UTF-8
+ ./node_modules/.bin/eslint 'warehouse/static/js/**' '**.js' 'tests/frontend/**' --ignore-pattern 'warehouse/static/js/vendor/**'
+ ./node_modules/.bin/sass-lint --verbose

Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with these changes! Thanks for taking the time to improve the codebase @kianmeng

@Borda
Copy link

Borda commented Jan 26, 2024

@di mind check it again, seems fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants