Skip to content

Ensure safe redirects on signup #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2013
Merged

Ensure safe redirects on signup #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02f4629
Ensure safe redirects on signup
dstufft Apr 29, 2013
3a18fd4
Fix the naming on "next" in LoginView
dstufft Apr 29, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions warehouse/accounts/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def dispatch(self, request, *args, **kwargs):

def post(self, request):
form = self.form_class(request.POST)
next = request.REQUEST.get("next", None)
next_url = request.REQUEST.get("next", None)

if form.is_valid():
# Attempt to authenticate the user
Expand All @@ -50,19 +50,19 @@ def post(self, request):
m = _("Invalid username or password")
form._errors.setdefault("__all__", form.error_class([])).append(m)

return self.render_to_response(dict(form=form, next=next))
return self.render_to_response(dict(form=form, next=next_url))

def get(self, request):
form = self.form_class()
next = request.REQUEST.get("next", None)
next_url = request.REQUEST.get("next", None)

return self.render_to_response(dict(form=form, next=next))
return self.render_to_response(dict(form=form, next=next_url))

def _get_next_url(self, request):
next = request.REQUEST.get("next", None)
if not is_safe_url(next, host=request.get_host()):
next = resolve_url(settings.LOGIN_REDIRECT_URL)
return next
next_url = request.REQUEST.get("next", None)
if not is_safe_url(next_url, host=request.get_host()):
next_url = resolve_url(settings.LOGIN_REDIRECT_URL)
return next_url


class SignupView(TemplateResponseMixin, View):
Expand All @@ -73,7 +73,7 @@ class SignupView(TemplateResponseMixin, View):

def post(self, request):
form = self.form_class(request.POST)
next = request.REQUEST.get("next", None)
next_url = request.REQUEST.get("next", None)

if form.is_valid():
# Create User
Expand All @@ -84,17 +84,17 @@ def post(self, request):
)

# Redirect to the next page
if next is None:
next = resolve_url(settings.LOGIN_REDIRECT_URL)
if not is_safe_url(next_url, host=request.get_host()):
next_url = resolve_url(settings.LOGIN_REDIRECT_URL)

return HttpResponseRedirect(next, status=303)
return HttpResponseRedirect(next_url, status=303)

return self.render_to_response(dict(form=form, next=next))
return self.render_to_response(dict(form=form, next=next_url))

def get(self, request):
form = self.form_class()
next = request.REQUEST.get("next", None)
next_url = request.REQUEST.get("next", None)

return self.render_to_response(dict(form=form, next=next))
return self.render_to_response(dict(form=form, next=next_url))

signup = SignupView.as_view()