Use InputRequired with explicit formdata
#13828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodruffw
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
User testing: confirmed functionality here.
There was a problem hiding this comment.
User testing: confirmed functionality here.
There was a problem hiding this comment.
User testing: confirmed functionality here.
There was a problem hiding this comment.
User testing: confirmed functionality here.
There was a problem hiding this comment.
(After fixing up the password reset form.)
di
approved these changes
Jun 5, 2023
…3696) * DataRequired -> InputRequired Signed-off-by: Jack Leightcap <[email protected]> * `make translations` Signed-off-by: William Woodruff <[email protected]> * pyproject: exclude webob.* from mypy There's no current tracking issue for supporting type hints in WebOb. Signed-off-by: William Woodruff <[email protected]> * pyproject: tracking issue Signed-off-by: William Woodruff <[email protected]> * tests: mash a type into place Signed-off-by: William Woodruff <[email protected]> --------- Signed-off-by: Jack Leightcap <[email protected]> Signed-off-by: William Woodruff <[email protected]> Co-authored-by: William Woodruff <[email protected]>
Signed-off-by: Jack Leightcap <[email protected]> Validated CreateMacaroonForm Signed-off-by: Jack Leightcap <[email protected]>
Signed-off-by: Jack Leightcap <[email protected]>
Signed-off-by: Jack Leightcap <[email protected]>
Signed-off-by: Jack Leightcap <[email protected]>
Signed-off-by: Jack Leightcap <[email protected]>
Signed-off-by: Jack Leightcap <[email protected]>
Signed-off-by: Jack Leightcap <[email protected]>
Signed-off-by: Jack Leightcap <[email protected]>
Signed-off-by: Jack Leightcap <[email protected]>
Signed-off-by: Jack Leightcap <[email protected]>
Signed-off-by: Jack Leightcap <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
|
Edit: Whoops, you beat me to it 😅 |
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
auto-merge was automatically disabled
June 5, 2023 14:46
Head branch was pushed to by a user without write access
|
Tests were failing because of a form rename; I've removed the old tests (since they're now covered by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer
InputRequiredoverDataRequiredSee wtforms note:
This PR removes instances of
DataRequired, and populates previously implicit data intoformdata.Testing Changes
test_validatethat gives an example of a valid construction and validation.Functional Refactors
All constructions of form objects outside of the definitions in
forms.py:warehouse/forklift/legacy.py
warehouse/manage/views/init.py
**self.request.POSTintoMultiDict.DeleteMacaroonfield into theformdataMultiDict.warehouse/manage/init.py
request, no change.warehouse/manage/views/organizations.py
default_response-- this is partially initialized, later with areponseobject. This is a general pattern, I'm not sure why?request, no change.warehouse/manage/views/teams.py
SaveTeamForm.warehouse/accounts/views.py
**request.first arg being wrapped in aMultiDict.request.paramsinstead ofrequest.POSTonreset_password?warehouse/views.py
SetLocaleFormconstruction.warehouse/manage/views/init.py
**self.request.POSTinMultiDict.warehouse/admin/views/users.py
UserFormtake a rawuserobject as the second arg?warehouse/admin/views/sponsors.py
SponsorFormandsponsorobject.warehouse/admin/views/banners.py