Remove creation of new index when reindexing #1473
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
new_index.create()
call from the reindexing command. I think the explicit call to create a new index is unnecessary, because elasticsearch will automatically create an index if it has not been created before.Furthermore, it is causing problems when reindexing in production:
index_already_exists_exception
instead (but still occasionally times out).The latter issue leads me to believe that this due to a race condition with the automatic index creation -- since our "temporary" index is given a randomly-generated name every time, I don't see any other way that the index could already exist.
I can't reproduce either exception in local development. However, I have verified that reindexing still creates a new index and runs as expected without this line.