-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add GitLab Trusted Publishing docs #15283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm okay with leaving the TODOs in for now, since this is going into another WIP branch that'll need subsequent updates anyways.
Just to highlight for review: this is for merge into |
Let's get the screenshots added here before we merge this (and after we merge #15275) so we can review this in one pass. |
@di screenshots added |
c7b7b88
to
39245ca
Compare
39245ca
to
2291e01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @facutuesca!
* Add GitLab Trusted Publishing docs * Add screenshots to GitLab Trusted Publishing docs * Fix instructions for GitLab CI with Trusted Publishing
* Add GitLab Trusted Publishing docs * Add screenshots to GitLab Trusted Publishing docs * Fix instructions for GitLab CI with Trusted Publishing
* docs/user: empty sections for more publishers Signed-off-by: William Woodruff <[email protected]> * Fix headings * Add provider TODOs to using-a-publisher.md * Move images into provider-specific directories * Update GitHub screenshots * Fix asset links * Update admonition to match * Remove unnecessary quoting * Google Trusted Publishing docs (#15195) * Google Trusted Publishing docs * Update docs/user/trusted-publishers/security-model.md Co-authored-by: Facundo Tuesca <[email protected]> * Update docs/user/trusted-publishers/security-model.md Co-authored-by: Facundo Tuesca <[email protected]> * Apply suggestions from code review Co-authored-by: William Woodruff <[email protected]> * Apply suggestions from code review --------- Co-authored-by: Facundo Tuesca <[email protected]> Co-authored-by: William Woodruff <[email protected]> * Add Google screenshots * Fix provider-specific screenshots * Add GitLab Trusted Publishing docs (#15283) * Add GitLab Trusted Publishing docs * Add screenshots to GitLab Trusted Publishing docs * Fix instructions for GitLab CI with Trusted Publishing * Add activestate OIDC docs (#15548) * First draft of ActiveState Trusted Publishing docs * Add ActiveState Security Model and Considerations * Adding examples * Add link to ActiveState hosted OIDC docs * Add updated docs from Andrew * MD tweaks and some images * Add remaining screenshots and embbed them in MD * Tweaking instructions for publishing * Update warehouse/templates/manage/account/publishing.html Co-authored-by: William Woodruff <[email protected]> * Review edit Co-authored-by: Dustin Ingram <[email protected]> * Review edits Co-authored-by: Dustin Ingram <[email protected]> * Review edits Co-authored-by: Dustin Ingram <[email protected]> * Review edits Co-authored-by: Dustin Ingram <[email protected]> * Review edits Co-authored-by: Dustin Ingram <[email protected]> * Translations * Fix build script tokens, link to supported platforms * Revise and reformat ActiveState using instructions --------- Co-authored-by: Pete Garcin <[email protected]> Co-authored-by: William Woodruff <[email protected]> Co-authored-by: Dustin Ingram <[email protected]> * Slugify tab anchors * Add blogpost announcing more trusted publishers (#15656) * Fix old byline * Add blogpost announcing more trusted publishers * Update docs/blog/posts/2024-04-20-expanding-trusted-publisher-support.md Co-authored-by: Mike Fiedler <[email protected]> * Apply suggestions from code review --------- Co-authored-by: Mike Fiedler <[email protected]> * Updating ActiveState publishing docs (#15739) * Updating ActiveState publishing docs * Update docs/user/trusted-publishers/using-a-publisher.md Co-authored-by: Dustin Ingram <[email protected]> --------- Co-authored-by: Dustin Ingram <[email protected]> * Update publish date * Update line for consistency * Update tabbed headings to not appear in ToC * Wrap long lines * Consistency fix * Line break * Strip out leading $ * Make note conform * Translations * Add border to images * Update screenshot * Dark mode CSS doesn't work as expected * Add alt text * Update publication date * Fix ActiveState getting started Trusted Publisher links (#15801) * Fix ActiveState getting started Trusted Publisher links * REALLY fix ActiveState getting started Trusted Publisher links --------- Signed-off-by: William Woodruff <[email protected]> Co-authored-by: William Woodruff <[email protected]> Co-authored-by: Facundo Tuesca <[email protected]> Co-authored-by: William Woodruff <[email protected]> Co-authored-by: Carey Hoffman <[email protected]> Co-authored-by: Pete Garcin <[email protected]> Co-authored-by: Mike Fiedler <[email protected]> Co-authored-by: Pete Garcin <[email protected]>
PR to merge into this other PR's branch: #15192
Adds the GitLab trusted publishing docs. The feature itself is implemented in #15275.
cc @woodruffw