Quote-encode backfill URLs #15503
Merged
Quote-encode backfill URLs #15503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketheman
approved these changes
Feb 28, 2024
| @@ -95,7 +96,7 @@ def metadata_backfill_individual(request, file_id): | |||
| return | |||
|
|
|||
| base_url = request.registry.settings.get("files.url") | |||
| file_url = base_url.format(path=file_.path) | |||
| file_url = urllib.parse.quote(base_url.format(path=file_.path), safe=":/") | |||
There was a problem hiding this comment.
Probably fine for the backfill, but we've been trying to only use one url parser, and settled on urllib3 - see #14497
There was a problem hiding this comment.
AFAICT, I'm not actually seeing a way to do this with urllib3. Given that we're going to be deleting this task in ~1 week, I'm just going to merge this as is!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WAREHOUSE-PRODUCTION-1QM.