refactor: apply 2FA to any non-exempt routes #15688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note to self: rebase and resolve conflicts with security policy once #15692 is out. |
As a precursor to further modification. reorder the behavior in the check. - Place both conditions behind a common `if` statement - Place the most-specific match first (file_upload) so that any further string matching won't affect this behavior Signed-off-by: Mike Fiedler <[email protected]>
New actions, such as reporting malware via web UI, now require 2FA. Signed-off-by: Mike Fiedler <[email protected]>
Leftover from pypi#15142 Signed-off-by: Mike Fiedler <[email protected]>
It's annoying to have to reauth when coming from a site like Inspector, increasing friction where it's not exactly warranted. If you're already logged in, that's good enough. Signed-off-by: Mike Fiedler <[email protected]>
Signed-off-by: Mike Fiedler <[email protected]>
miketheman
force-pushed
the
miketheman/2fa-4-all
branch
from
c481bbf to
bbfb495
Compare
di
reviewed
Apr 1, 2024
Signed-off-by: Mike Fiedler <[email protected]>
di
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New actions, such as reporting malware via web UI, now require 2FA.
Contains other commits, making this change easier to implement. Please review individually.