Add base_publisher_url to file/release events.
#15872
Conversation
| ) | ||
| DBFileEventFactory.create( | ||
| source=release_file, | ||
| tag="fake:event", | ||
| additional={"publisher_url": publisher_url}, | ||
| additional={"base_publisher_url": base_publisher_url}, |
There was a problem hiding this comment.
Why do we need this second event?
There was a problem hiding this comment.
To catch the bug that this commit fixed: 7f93c42. It was failing because it doesn't work when there are multiple events found.
There was a problem hiding this comment.
I see!! Awesome! Thanks!
|
Out of date and mostly resolved by #16205 (@facutuesca, you might want to see if there's anything else we can use from this). |
I see that here the extra field is added to the file upload events. While the additional field being added is the same ( Since we are now verifying URLs at the time of the file upload (and storing the |
|
Agreed! |
This fixes an issue with #15862, where the
publisher_urlfor most events contained a commit SHA, and therefore had additional parts that made it hard to compare with project URLs.The workaround is to introduce a
base_publisher_urladditional field that represents the unique "root" of the publisher for all publishers (i.e. the github repo) which we can use to compare to project URLs to verify them.This means that these links will become verified only once a new event is published with this additional field, which should slowly happen over time.
To speed this up, we could do a one-off data migration to add
base_publisher_urlto existing events, but I think this should be fine as-is.