Skip to content

Update workflows #17513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Update workflows #17513

merged 4 commits into from
Jan 28, 2025

Conversation

DarkaMaul
Copy link
Contributor

This PR contains two workflow improvements:

  1. Removes redundant default setting (per @di's feedback in Use zizmor from PyPI #17512 (comment))
  2. Optimizes CI performance by running zizmor checks only when .github/workflows/** files change

Note: While change #2 reduces CI load, new zizmor checks won't run until either:

  • Workflow files are modified
  • Weekly scheduled run occurs (Monday)

I am happy to split these changes into separate PRs if preferred.

/cc @woodruffw

@DarkaMaul DarkaMaul requested a review from a team as a code owner January 28, 2025 16:04
@di
Copy link
Member

di commented Jan 28, 2025

Note: While change #2 reduces CI load, new zizmor checks won't run until either

FWIW I don't think CI load has been an issue here. I assume this also mean that we won't run new versions of zizmor until we modify workflows / the cron runs as well, correct? I think I'm OK with keeping the workflow as-is to ensure we're up to date.

Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DarkaMaul!

@di di merged commit aa613c1 into pypi:main Jan 28, 2025
20 checks passed
@di di deleted the dm/update-workflows branch January 28, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants