update project description - fix code rendering #3397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
di
approved these changes
Mar 24, 2018
miketheman
added a commit
to miketheman/warehouse
that referenced
this pull request
Jan 6, 2023
Introduced in pypi#3397 Raises lint error for `no-duplicate-selectors`. - Remove duplication - Disable lint rule for the Pygments block, since it helps us visually organize our thoughts. Signed-off-by: Mike Fiedler <[email protected]>
di
pushed a commit
that referenced
this pull request
Jan 6, 2023
* chore(deps): install stylelint for SCSS Signed-off-by: Mike Fiedler <[email protected]> * lint: add stylelint configuration Trying to match the existing `.sass-lint.yml` rules as much as we can. Signed-off-by: Mike Fiedler <[email protected]> * lint: address whitespace Fixed based on the stylelint rules. There's 65 remaining fixes if we choose to change enable: - at-rule-empty-line-before - declaration-empty-line-before Signed-off-by: Mike Fiedler <[email protected]> * lint: address pseudo selectors With `selector-pseudo-element-colon-notation` enabled, we double-colon pseudo selectors for visual specificity. Signed-off-by: Mike Fiedler <[email protected]> * lint: rename disables Signed-off-by: Mike Fiedler <[email protected]> * lint: handle shorthand properties Refs: https://stylelint.io/user-guide/rules/shorthand-property-no-redundant-values/ Signed-off-by: Mike Fiedler <[email protected]> * lint: simplify complex .not notation Refs: https://stylelint.io/user-guide/rules/selector-not-notation/ Signed-off-by: Mike Fiedler <[email protected]> * lint: handle color lints Solves: - alpha-value-notation: 5 - color-function-notation: 5 - color-hex-case: 3 - color-hex-length: 1 Signed-off-by: Mike Fiedler <[email protected]> * lint: handle various one-off cases - declaration-block-trailing-semicolon: 2 - font-family-name-quotes: 1 - length-zero-no-unit: 1 - number-leading-zero: 1 - property-no-vendor-prefix: 1 - value-keyword-case: 1 Signed-off-by: Mike Fiedler <[email protected]> * lint: remove duplicate selectors Introduced in #3397 Raises lint error for `no-duplicate-selectors`. - Remove duplication - Disable lint rule for the Pygments block, since it helps us visually organize our thoughts. Signed-off-by: Mike Fiedler <[email protected]> * refactor: replace my janky regex with plugin Instead of trying to decipher in the future how I came up with the selector pattern, use a plugin that implements the right selector syntaxes. We disable the inherited `selector-class-pattern` rule from `stylelint-config-standard`. Refs: stylelint/stylelint-config-standard#209 Signed-off-by: Mike Fiedler <[email protected]> * test: run stylelint instead of sass-lint Signed-off-by: Mike Fiedler <[email protected]> * chore: remove deprecated sass-lint Signed-off-by: Mike Fiedler <[email protected]> Signed-off-by: Mike Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3330
Also makes project release styles more robust - all elements now use margins at the top, for more consistent rendering.