Skip to content

Missing verified email url #3406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Missing verified email url #3406

wants to merge 7 commits into from

Conversation

saxenanurag
Copy link
Contributor

Change the hard coded pypi url with the pyramid route_url method. Fix for #3184

@brainwane
Copy link
Contributor

Thank you @saxenanurag!

Thanks for writing a descriptive commit message. It would be great if your commit message were a bit more descriptive -- https://zulip.readthedocs.io/en/latest/version-control.html#commit-messages is a good guide (from a different project) to writing commit messages that make it easier to understand what a commit is doing. (A clear commit message also makes debugging in the future easier -- when someone's trying to solve a new problem, if commit messages are all in the same format, it's easier to skim them in logs and quickly understand what's happening.)

Here are some tips on tidying your commit history, including changing your commit messages. And when you update your code or your commit message, you can update your pull request and the changes will appear here. :)

And you don't need to close the old one and open a new one. You can update your pull request and we recommend you do that (instead of closing the old PR and opening a new one) because then it's easier to see the history of what you've done, to to check that you've responded to previous reviewers' comments, and to preserve links we've mentioned (in comments) with other issues and PRs.

Sorry if any of this is redundant! If you have questions, please feel free to ask them here, in #pypa-dev on Freenode, or on the pypa-dev mailing list.

@saxenanurag
Copy link
Contributor Author

Thank you so much @brainwane !

I will make the changes and push changes.

@brainwane
Copy link
Contributor

Looking forward to it. Thanks, @saxenanurag.

@brainwane
Copy link
Contributor

@saxenanurag I'm going to close this and ask you to concentrate on one pull request at a time, at least for now -- concentrate on #3405, and then when that's done, let's have you work on another issue. Thanks!

@brainwane brainwane closed this Apr 1, 2018
@saxenanurag saxenanurag deleted the missing-verified-email-url branch April 2, 2018 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants