-
Notifications
You must be signed in to change notification settings - Fork 1k
Add classifier FAQ, link to from filters #3484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not taking the time to run this branch myself, but:
I get that we're pointing the user to the help page anchor ("Each project's maintainers....") when clicking on the "?" icon. Do we do that with just a regular link or do we do anything fancy here like open a new little window/tab? Either way is fine, just trying to assess.
warehouse/templates/pages/help.html
Outdated
@@ -55,6 +56,7 @@ <h1 class="page-title">Common Questions</h1> | |||
<h2 class="faq-group__first"><a href="#basics">Basics</a></h2> | |||
<ul> | |||
<li><a href="#packages">{{ packages() }}</a></li> | |||
<li><a href="#trove-classifier">{{ trove_classifier() }}</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd put the trove classifier item below "How do I package and publish my code for PyPI?".
warehouse/templates/pages/help.html
Outdated
<h3 id="trove-classifier">{{ trove_classifier() }}</h3> | ||
|
||
<p>Each project's maintainers provide PyPI with a list of "trove classifiers" to categorize each release, describing who it's for, what systems it can run on, and how mature it is.</p> | ||
<p>These classifiers can then be used by community members to find projects based on their desired criteria.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I showed this wording to another maintainer (my spouse Leonard, thanks Leonard!) and he suggested:
These standardized classifiers can then be used
so let's do that to get across that they're standardized across the community.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my previous review should have been "request changes".
Updated and ready to re-review @brainwane. The link is just a standard link (opens in the same tab). This is how our other help tooltips currently work. If we want to change this, I think we should make a separate PR to change all at the same time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes #3452