Move email handling into a service #3493
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves email handling into a service, this is done to prepare for eventual SES support (which will not go through SMTP, but rather through the SES API). Functionally speaking this doesn't change anything, but codewise a few APIs have changed:
warehouse.email:send_email()
no longer takes arecipients
and abcc
kwarg, instead it takes a singlerecipient
kwarg.warehouse.email:send_mail()
multiple times. This is better because when end users receive the email, it will still have their email in theTo:
field, instead of no address.warehouse.email:send_email()
has changed and subject must be passed first.This change does not introduce anything like configurable services for sending email, future PRs will include that, but this moves us closer to being able to swap out the email handling at runtime.