Refactor readme rendering logic #3760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gentle ping on this. |
|
@aalmazan can you review this, if you have time? |
|
I am (very slowly) reviewing & testing this. |
di
approved these changes
May 2, 2018
tests/unit/packaging/test_views.py
Outdated
| @@ -180,6 +180,7 @@ def test_detail_renders(self, db_request): | |||
| "project": project, | |||
| "release": releases[1], | |||
| "files": [files[1]], | |||
| "description": None, | |||
There was a problem hiding this comment.
Could you add a description to the ReleaseFactory.create call above, monkeypatch readme.render, assert that it's called w/ Release.description, and assert that this value is the stub from that call?
|
@di this should be ready to go now. |
di
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3739
Original context: #3745