Remove De-normalization Of Name and Version #4974
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we were using natural primary keys, a lot of tables had name and version keys on them, since that was how the FKs worked. With the move to surrogate keys for all of our primary keys, these existing name and version fields are just leftover bits of denormalization that needs to be handled.
In #4958 (comment) I laid out a few options for solving this. This PR represents choice (3).
There may be performance implications here, I've tried to keep any index that still seemed like it made sense, but this is sort of drastically altering the performance characteristics of some of these queries, so it's possible that there will be a performance regression. However, if there is we can, at that time, either solve it with additional indexes or perhaps choose to denormalize our data then.