Render description HTML on upload #5818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstufft
force-pushed
the
cached-description
branch
from
f1dbb61 to
dc2cef1
Compare
dstufft
force-pushed
the
cached-description
branch
from
dc2cef1 to
2b94541
Compare
dstufft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renders the description when the file gets uploaded instead of during each HTTP request to a project page. It will also store the version of readme_renderer that was used to render the description, and a periodic task will look for anything that wasn't rendered using the current renderer version (in batches of 5000).
This PR currently will fallback to rendering the description inline if there isn't a
Release.description.html, but in the future we will remove that fallback and require thatRelease.description.htmlhas been set. The fallback exists entirely to keep things working until the cronjob has backfilled all of the data.Fixes #3739