Skip to content

fixes issue #6880 #6886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 14, 2020
Merged

fixes issue #6880 #6886

merged 6 commits into from
Jan 14, 2020

Conversation

sargamm
Copy link
Contributor

@sargamm sargamm commented Oct 20, 2019

I have changed the overflow property for the required classes in author-profile.scss.

Fixes #6880.

@di
Copy link
Member

di commented Oct 21, 2019

Screenshot of this change:

Screen Shot 2019-10-21 at 11 06 28 AM

I think we need some additional discussion in #6880.

@sargamm
Copy link
Contributor Author

sargamm commented Oct 23, 2019

I have made the required changes. Please have a look

@di
Copy link
Member

di commented Oct 29, 2019

This hides the overflow instead of wrapping it:

Screen Shot 2019-10-29 at 4 45 53 PM

Are you able to run warehouse locally and test these changes before committing them?

@sargamm
Copy link
Contributor Author

sargamm commented Dec 17, 2019

I tested locally, it's working for me. Just recheck once @di

@di
Copy link
Member

di commented Jan 2, 2020

Sorry, but it still doesn't work. The name wraps but the username just overflows and the overflow is hidden.

Screen Shot 2020-01-02 at 4 07 37 PM

You'll want to remove the overflow: hidden; line you've added (we never want this to happen) and instead add word-wrap: break-word; to the &__meta block, as this is the "metadata" including the username that is shown in the author profile.

@sargamm
Copy link
Contributor Author

sargamm commented Jan 12, 2020

Oh I misunderstood it and did only for the Name,sorry! I have made the required changes now. can you have a look?

@di
Copy link
Member

di commented Jan 14, 2020

This looks correct now:

Screen Shot 2020-01-14 at 2 09 48 PM

@di di merged commit 6209f70 into pypi:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long username overflows on profile page
2 participants