Skip to content

add missing primary key constraints #7129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2019
Merged

add missing primary key constraints #7129

merged 2 commits into from
Dec 19, 2019

Conversation

ewdurbin
Copy link
Member

addresses #7128

@ewdurbin ewdurbin requested a review from dstufft December 19, 2019 15:06
@ewdurbin ewdurbin force-pushed the missing_primary_keys branch from 6be2f31 to 323e3af Compare December 19, 2019 15:17
@ewdurbin ewdurbin requested a review from di December 19, 2019 18:03
@ewdurbin
Copy link
Member Author

generated SQL:

ALTER TABLE release_files ADD PRIMARY KEY (id);

ALTER TABLE release_dependencies ADD PRIMARY KEY (id);

ALTER TABLE roles ADD PRIMARY KEY (id);

UPDATE alembic_version SET version_num='b5bb5d08543d' WHERE alembic_version.version_num = '08aedc089eaf';

COMMIT;

@ewdurbin
Copy link
Member Author

I've confirmed that this migration is rather quick, and syncs SQLAlchemy's view of the DB with reality, so I'm gonna go ahead and ship it.

@ewdurbin ewdurbin merged commit 192e609 into master Dec 19, 2019
@ewdurbin ewdurbin deleted the missing_primary_keys branch December 19, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant