Skip to content

upgrade to Python 3.8.2 #7828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 22, 2020
Merged

upgrade to Python 3.8.2 #7828

merged 9 commits into from
Apr 22, 2020

Conversation

ewdurbin
Copy link
Member

:=

@ewdurbin ewdurbin force-pushed the python38 branch 2 times, most recently from 26d5432 to 29f6ed1 Compare April 22, 2020 14:19
ewdurbin
ewdurbin commented Apr 22, 2020
View reviewed changes
.travis.yml
@@ -31,6 +31,7 @@ install:
- nvm install $TRAVIS_NODE_VERSION
- pip install -U pip setuptools wheel
- pip install -r requirements/main.txt -r requirements/deploy.txt -r requirements/docs.txt -r requirements/lint.txt -r requirements/tests.txt
- pip install -r requirements/dev.txt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm honestly not exactly sure what changed that required this, it seems pip-tools was being installed some other way before, might relate to bumping travis dist to bionic

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also while tracking this down I noticed that in CI we are installing everything into the virtualenv travis automatically creates for us, but then reinstalling it into the .state/env we construct... but never use.

ewdurbin
ewdurbin commented Apr 22, 2020
View reviewed changes
ewdurbin
ewdurbin commented Apr 22, 2020
View reviewed changes
requirements/main.txt
@@ -294,10 +294,6 @@ idna==2.9 \
--hash=sha256:7588d1c14ae4c77d74036e8c22ff447b26d0fde8f007354fd48a7814db15b7cb \
--hash=sha256:a068a21ceac8a4d63dbfd964670474107f541babbd2250d61922f029858365fa \
# via email-validator, requests
importlib-metadata==1.6.0 \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for this back port anymore!

@ewdurbin ewdurbin requested a review from di April 22, 2020 14:22
di
di reviewed Apr 22, 2020
View reviewed changes
@di
Copy link
Member

di commented Apr 22, 2020

It seems like pip-compile is doing a kind of funny thing where it won't add additional hashes or upgrade a subdependency if the "outfile" already exists and the dependency is already listed there.

I removed all the .txt files and recompiled all dependencies, which gave us some additional annotations, some new hashes for late-added built distributions (cryptography, sqlalchemy), and upgrades for some subdependencies (zope.deprecation, zope.interface and zope.sqlalchemy)

di
di approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ewdurbin We've got passing CI here whenever you're feeling adventurous!

@ewdurbin ewdurbin merged commit fd7bc00 into master Apr 22, 2020
@ewdurbin ewdurbin deleted the python38 branch April 22, 2020 23:44
@ewdurbin
Copy link
Member Author

@pradyunsg
Copy link
Contributor

looks at this nice.
looks at pip oh right, Python 2. One day, we'll get here too.

MVrachev added a commit to MVrachev/tuf that referenced this pull request Jan 19, 2022
@MVrachev
Drop support for python version 3.6
0f59f4b 
Python version 3.6 was supported until December 23-rd 2021 meaning its
end of life has expired before more than 20 days.
Dropping support for python version 3.6 will allow us to remove
OrderedDicts.

After a quick check I saw that Warehouse target python version 3.8.2:
- their docker file: https://github.com/pypa/warehouse/blob/main/Dockerfile#L47
- https://github.com/pypa/warehouse/blob/main/.python-version
- last pr updating pr version: pypi/warehouse#7828
Pip supports python version 3.7+ as well. They dropped python 3.6 a
couple of months ago:
pypa/pip#10641

This means it shouldn't cause headache to our users if we drop python
version 3.6 too.

Signed-off-by: Martin Vrachev <[email protected]>
@MVrachev MVrachev mentioned this pull request Jan 19, 2022
Merged
MVrachev added a commit to MVrachev/securesystemslib that referenced this pull request Jan 27, 2022
@MVrachev
Drop support for python version 3.6
195e1d2 
Python version 3.6 was supported until December 23-rd 2021
(see https://endoflife.date/python) meaning its end of life has expired
before more than 20 days.
Dropping support for python version 3.6 will allow us to make some
small cleanups.

After a quick check I saw that Warehouse target python version 3.8.2:
- their docker file: https://github.com/pypa/warehouse/blob/main/Dockerfile#L47
- https://github.com/pypa/warehouse/blob/main/.python-version
- last pr updating pr version: pypi/warehouse#7828
Pip supports python version 3.7+ as well. They dropped python 3.6 a
couple of months ago:
pypa/pip#10641

This means it shouldn't cause headache to our users if we drop python
version 3.6 too.

Signed-off-by: Martin Vrachev <[email protected]>
@MVrachev MVrachev mentioned this pull request Jan 27, 2022
Merged
3 tasks
@di di mentioned this pull request Feb 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamadden jamadden jamadden left review comments

@di di di approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ewdurbin @di @pradyunsg @jamadden