Skip to content

2.6.1 Release #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
snowman2 opened this issue May 2, 2020 · 10 comments
Closed
4 tasks done

2.6.1 Release #611

snowman2 opened this issue May 2, 2020 · 10 comments

Comments

@snowman2
Copy link
Member

snowman2 commented May 2, 2020 •
edited
Loading

https://github.com/pyproj4/pyproj/releases/tag/2.6.1rc0

The plan is to release with PROJ 7.0.1 in the wheels

Release Candidate 0 Status:

Plan to release when testing is completed or May 4th. Testing is always appreciated, but definitely not required.
@sebastic
Copy link
Contributor

sebastic commented May 2, 2020

The Debian package builds fine so far:

https://buildd.debian.org/status/package.php?p=python-pyproj&suite=experimental

It will take a little more time to get results for autopkgtest:

https://release.debian.org/britney/pseudo-excuses-experimental.html#python-pyproj

@cgohlke
Copy link
Contributor

cgohlke commented May 2, 2020

I get one test error on Windows. PROJ 7.0.1 was built without tiff and curl.

platform win32 -- Python 3.8.2, pytest-5.4.1, py-1.8.1, pluggy-0.13.1
rootdir: D:\Build\pyproj\pyproj-2.6.1rc0
plugins: hypothesis-5.10.4, palladium-1.2.2, cov-2.8.1, forked-1.1.3, xdist-1.31.0
collected 549 items

test\test__main__.py ...                                                                                         [  0%]
test\test_awips221.py .                                                                                          [  0%]
test\test_datadir.py ..........                                                                                  [  2%]
test\test_datum.py ..                                                                                            [  2%]
test\test_datum_shift.py ....                                                                                    [  3%]
test\test_doctest_wrapper.py .                                                                                   [  3%]
test\test_exception_logging.py ..                                                                                [  4%]
test\test_geod.py ............................                                                                   [  9%]
test\test_list.py ...................                                                                            [ 12%]
test\test_pickle.py .                                                                                            [ 12%]
test\test_proj.py .................................                                                              [ 18%]
test\test_show_versions.py ....                                                                                  [ 19%]
test\test_transform.py ..                                                                                        [ 20%]
test\test_transformer.py ......................................................F..............                   [ 32%]
test\test_utils.py .........                                                                                     [ 34%]
test\crs\test_crs.py ........................................................................................... [ 50%]
................................................................................................................ [ 71%]
.                                                                                                                [ 71%]
test\crs\test_crs_cf.py .....................................                                                    [ 78%]
test\crs\test_crs_coordinate_operation.py ...............................................                        [ 86%]
test\crs\test_crs_coordinate_system.py ......................                                                    [ 90%]
test\crs\test_crs_datum.py .......                                                                               [ 91%]
test\crs\test_crs_json.py ...............................                                                        [ 97%]
test\crs\test_crs_maker.py .............                                                                         [100%]

====================================================== FAILURES =======================================================
_________________________________________ test_transform_group__missing_best __________________________________________

    def test_transform_group__missing_best():
        with pytest.warns(FutureWarning):
            lat_lon_proj = pyproj.Proj(init="epsg:4326", preserve_units=False)
            alaska_aea_proj = pyproj.Proj(init="epsg:2964", preserve_units=False)

        if not grids_available("ntv2_0.gsb", "ca_nrc_ntv2_0.tif"):
            with pytest.warns(
                UserWarning,
                match="Best transformation is not available due to missing Grid",
            ):
                trans_group = pyproj.transformer.TransformerGroup(
                    lat_lon_proj.crs, alaska_aea_proj.crs
                )

            assert not trans_group.best_available
            assert len(trans_group.transformers) == 37
            assert len(trans_group.unavailable_operations) == 41
        else:
            # assuming all grids avaiable or PROJ_NETWORK=ON
            trans_group = pyproj.transformer.TransformerGroup(
                lat_lon_proj.crs, alaska_aea_proj.crs
            )
            assert trans_group.best_available
>           assert len(trans_group.transformers) == 78
E           assert 39 == 78
E            +  where 39 = len([<Concatenated Operation Transformer: pipeline>\nDescription: Inverse of NAD27 to WGS 84 (33) + unknown\nArea of Use:\n- ...o WGS 84 (85) + unknown\nArea of Use:\n- name: USA - Alaska including EEZ\n- bounds: (167.65, 47.88, -129.99, 74.71), ...])
E            +    where [<Concatenated Operation Transformer: pipeline>\nDescription: Inverse of NAD27 to WGS 84 (33) + unknown\nArea of Use:\n- ...o WGS 84 (85) + unknown\nArea of Use:\n- name: USA - Alaska including EEZ\n- bounds: (167.65, 47.88, -129.99, 74.71), ...] = <TransformerGroup: best_available=True>\n- transformers: 39\n- unavailable_operations: 39.transformers

test\test_transformer.py:605: AssertionError
================================================== warnings summary ===================================================
test/test_transformer.py::test_transformer_group__get_transform_crs
  D:\Build\pyproj\pyproj-2.6.1rc0\pyproj\transformer.py:73: UserWarning: Best transformation is not available due to missing Grid(short_name=nl_nsgi_rdtrans2018.tif, full_name=, package_name=, url=https://cdn.proj.org/nl_nsgi_rdtrans2018.tif, direct_download=True, open_license=True, available=False)
    super().__init__(

-- Docs: https://docs.pytest.org/en/latest/warnings.html
=============================================== short test summary info ===============================================
FAILED test/test_transformer.py::test_transform_group__missing_best - assert 39 == 78
====================================== 1 failed, 548 passed, 1 warning in 32.66s ======================================

@snowman2
Copy link
Member Author

snowman2 commented May 2, 2020

@djhoese, looks like pyresample is failing:

description', '',
/usr/lib/python3/dist-packages/pyresample/geometry.py:1131: in __init__
    corner_lons, corner_lats = proj((area_extent[0], area_extent[2]),
/usr/lib/python3/dist-packages/pyresample/_spatial_mp.py:136: in __call__
    return super(Proj, self).__call__(data1, data2, inverse=inverse,
E   TypeError: __call__() got an unexpected keyword argument 'radians'

This is due to changes in #591

@snowman2
Copy link
Member Author

snowman2 commented May 2, 2020

@sebastic autopkgtest is pretty neat 👍

@snowman2
Copy link
Member Author

snowman2 commented May 2, 2020

@cgohlke what datumgrids are you including?

This was referenced May 2, 2020
Closed
Merged
@snowman2
Copy link
Member Author

snowman2 commented May 3, 2020 •
edited
Loading

https://github.com/pyproj4/pyproj/releases/tag/2.6.1rc1

Release Candidate 1 Status:

@sebastic
Copy link
Contributor

sebastic commented May 3, 2020

The Debian package has been updated:

https://buildd.debian.org/status/package.php?p=python-pyproj&suite=experimental

@snowman2
Copy link
Member Author

snowman2 commented May 4, 2020

The release is ready & will start building wheels soon: https://github.com/pyproj4/pyproj/releases/tag/v2.6.1rel

Thanks @sebastic and @cgohlke for testing!

Side note: #613 should allow pyresample to work with this release.

@snowman2 snowman2 closed this as completed May 4, 2020
@snowman2
Copy link
Member Author

snowman2 commented May 4, 2020

2.6.1.post1 coming tomorrow sometime ... manifest updates.

@snowman2
Copy link
Member Author

snowman2 commented May 4, 2020

2.6.1.post1 is now on pypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cgohlke @sebastic @snowman2