Allow Cargo.lock hash to be provided when using importCargoLock #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
charles-dyfis-net
force-pushed
the
allow-explicit-lock-hash
branch
2 times, most recently
from
a874606 to
9556f07
Compare
Add optional cargoLockHash parameter that makes Cargo.lock extraction a fixed-output derivation. Use pkgsBuildHost rather than pkgs for build -- as a FOD, this doesn't change the build hash. This allows platforms that are doing cross-evalution but not cross-compilation to generate identical derivation hashes between cross-evaluation and local build, so long as they (1) provide a hash for Cargo.lock files, and (2) ensure that `pkgsBuildHost` is set to reflect the system doing the evaluation.
charles-dyfis-net
force-pushed
the
allow-explicit-lock-hash
branch
from
9556f07 to
7362e9b
Compare
|
Could you explain the use case in greater detail? I don't really understand what this is supposed to solve. |
Sure. I have a flake using pyproject.nix, and I want Right now it doesn't, because when evaluating the derivation for a different target we need to get the lockfile to parse, and the "get the lockfile" steps are run with the target pkgs instead of the local one. When the lockfile is a FOD, it has the same hash no matter how it was built, so we can reuse a copy of the lockfile extracted with local tools when evaluating the same build for a different target platform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkgsBuildHostto evaluate that FOD. (This may be identical topkgsin the absence of cross-compilation; folks intending to support cross-eval will need to take explicit steps).