Skip to content

Update threading.Event.isSet() calls #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions execnet/gateway_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ def _try_send_to_primary_thread(self, reply):
# note that we should be called with _running_lock hold
primary_thread_task_ready = self._primary_thread_task_ready
if primary_thread_task_ready is not None:
if not primary_thread_task_ready.isSet():
if not primary_thread_task_ready.is_set():
self._primary_thread_task = reply
# wake up primary thread
primary_thread_task_ready.set()
Expand Down Expand Up @@ -591,7 +591,7 @@ def setcallback(self, callback, endmarker=NO_ENDMARKER_WANTED):
try:
olditem = items.get(block=False)
except self.gateway.execmodel.queue.Empty:
if not (self._closed or self._receiveclosed.isSet()):
if not (self._closed or self._receiveclosed.is_set()):
_callbacks[self.id] = (callback, endmarker, self._strconfig)
break
else:
Expand All @@ -616,7 +616,7 @@ def __del__(self):
# state transition "closed" --> "deleted"
for error in self._remoteerrors:
error.warn()
elif self._receiveclosed.isSet():
elif self._receiveclosed.is_set():
# state transition "sendonly" --> "deleted"
# the remote channel is already in "deleted" state, nothing to do
pass
Expand Down Expand Up @@ -682,7 +682,7 @@ def close(self, error=None):
# but it's never damaging to send too many CHANNEL_CLOSE messages
# however, if the other side triggered a close already, we
# do not send back a closed message.
if not self._receiveclosed.isSet():
if not self._receiveclosed.is_set():
put = self.gateway._send
if error is not None:
put(Message.CHANNEL_CLOSE_ERROR, self.id, dumps_internal(error))
Expand Down Expand Up @@ -711,7 +711,7 @@ def waitclose(self, timeout=None):
"""
# wait for non-"opened" state
self._receiveclosed.wait(timeout=timeout)
if not self._receiveclosed.isSet():
if not self._receiveclosed.is_set():
raise self.TimeoutError("Timeout after %r seconds" % timeout)
error = self._getremoteerror()
if error:
Expand Down