-
Notifications
You must be signed in to change notification settings - Fork 43
Specify encoding in fdopen. #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify encoding in fdopen. #196
Conversation
This change doesn't fix but reveals many more EncodingWarnings in tests (but no more in the library).
|
Thanks @jaraco! We can live with the warnings in the tests for now. 👍 |
25ecd39
to
e2e0852
Compare
🎉 I was just trying to enable ...do we have release plans though? It's been two years, but v1.9.0...master is a lot of bugfixes to keep off PyPI. I'm just going to install from the commit, but it'd be nice to share more widely. |
Fixes #195