Skip to content

No longer silently skip setuptools plugins that raise DistributionNotFound errors #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

nicoddemus
Copy link
Member

Fix #174

@RonnyPfannschmidt
Copy link
Member

it should be noted that this is a breaking api change if applied to pytest as is

@nicoddemus
Copy link
Member Author

Not sure Ronny, I think this is a bug fix,also that api is not really exposed by pytest is it?

@RonnyPfannschmidt
Copy link
Member

This bugfix adds New exit points

@nicoddemus
Copy link
Member Author

True. Oh well, this will have to come later then.

@nicoddemus nicoddemus closed this Aug 19, 2018
@nicoddemus nicoddemus deleted the do-not-swallow-dist-error branch August 19, 2018 13:20
@goodboy
Copy link
Contributor

goodboy commented Aug 20, 2018

if it's breaking can't we just make it part of pluggy 1.0?

@nicoddemus
Copy link
Member Author

The problem is that it will break pytest, for pluggy this change is fine, as being 0.X you are allowed for backward incompatible changes.

Just realized that one way to move this forward is to instead trigger a warning. This might be even the final solution in the long run. What do you think @RonnyPfannschmidt?

@RonnyPfannschmidt
Copy link
Member

lets move the entry-point iteration/loading to a helper that for a grace period will be warning about errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants