i18n: more accurate line width estimate...possible? #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idth asian characters, accented latin characters
nicoddemus
approved these changes
Aug 26, 2018
CHANGELOG
Outdated
| @@ -1,3 +1,11 @@ | |||
| 1.5.5 (unreleased) | |||
There was a problem hiding this comment.
This will need to be 1.6.0 as adds a new functionality. 👍
py/_io/terminalwriter.py
Outdated
| def width_of_current_line(self): | ||
| """Return an estimate of the width so far in the current line. | ||
| .. versionadded:: 1.5.5 |
There was a problem hiding this comment.
Update version here as well please.
nicoddemus
requested changes
Aug 26, 2018
|
@nicoddemus any idea what's going on in the appveyor build failure? doesn't look like any module I've touched? |
|
Hmmm seems like a flaky test, let me trigger the build again to confirm |
nicoddemus
approved these changes
Aug 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example taking into account full width asian characters, combining accents in latin characters, etc. - it's not entirely trivial because Python module filenames can for example have accents.
This is going to be extremely difficult to handle correctly 100% of the time, without a big performance hit, and this is just a start (plus some testing) for trying to provide a number that may hopefully be more reliable than the string length.
pytest without this stuff:
pytest with this stuff: