Skip to content

pyimport: add support for PY_IGNORE_IMPORTMISMATCH #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2018
Merged

pyimport: add support for PY_IGNORE_IMPORTMISMATCH #199

merged 1 commit into from
Oct 10, 2018

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Sep 25, 2018

@blueyed blueyed mentioned this pull request Sep 25, 2018
Closed
@nicoddemus
Copy link
Member

Thanks @blueyed!

LGTM, just missing a CHANGELOG entry which we can add later before doing a release.

I'm leaving to @RonnyPfannschmidt to take a look and see if he has any objections still. 👍

@nicoddemus nicoddemus merged commit 3c23d42 into pytest-dev:master Oct 10, 2018
@blueyed blueyed deleted the PY_IGNORE_IMPORTMISMATCH branch October 11, 2018 00:27
@bbisk bbisk mentioned this pull request Jan 11, 2019
Merged
@malthe
Copy link

malthe commented Jan 23, 2020

Shouldn't this be configurable in "pytest.ini" - ?

@blueyed
Copy link
Contributor Author

blueyed commented Jan 23, 2020

@malthe
That would be an issue for pytest, but I think it is good enough allowing to set this via env - after all it should not really happen in the first place etc.

drewejohnson pushed a commit to CORE-GATECH-GROUP/hydep that referenced this pull request Feb 25, 2021
Use PY_IGNORE_IMPORTMISMATCH in runtests
12471f3 
Avoids ImportMismatchError due to pytest finding installed hydep and
src/hydep
pytest-dev/py#199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get rid of "ImportMismatchError"
3 participants
@blueyed @nicoddemus @malthe